Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster command arguments for issue_zigbee_cluster_command service. #28885

Merged
merged 1 commit into from Nov 20, 2019

Conversation

Adminiuga
Copy link
Contributor

@Adminiuga Adminiuga commented Nov 20, 2019

Description:

Allow specification of cluster command arguments for zha.issue_zigbee_cluster_command service.
For example a move_to_level_with_on_off command on Level cluster of a light:

ieee: '7c:b0:3e:aa:00:ab:cd:ef'
endpoint_id: 3
cluster_id: 8
cluster_type: in
command: 0
command_type: server
args:
  - 254
  - 20

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as its been labeled with a integration (zha) you are listed as a codeowner for? Thanks!

@Adminiuga Adminiuga added small-pr PRs with less than 30 lines. and removed small-pr PRs with less than 30 lines. labels Nov 20, 2019
@MartinHjelmare MartinHjelmare added this to Needs review in Dev Nov 20, 2019
Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Dev automation moved this from Needs review to Reviewer approved Nov 20, 2019
@dmulcahey dmulcahey merged commit 4ba2bd2 into home-assistant:dev Nov 20, 2019
Dev automation moved this from Reviewer approved to Done Nov 20, 2019
@lock lock bot locked and limited conversation to collaborators Nov 21, 2019
@Adminiuga Adminiuga deleted the ac/zha-cluster-command branch January 15, 2020 02:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants