Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rendering complex template objects to leave non-template values alone #29353

Merged
merged 1 commit into from Dec 3, 2019
Merged

Rendering complex template objects to leave non-template values alone #29353

merged 1 commit into from Dec 3, 2019

Conversation

balloob
Copy link
Member

@balloob balloob commented Dec 3, 2019

Description:

Rendering complex template objects will now leave non-string values alone, since they can never be templates to begin with.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner December 3, 2019 21:18
@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Dec 3, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 3, 2019
@robbiet480 robbiet480 mentioned this pull request Dec 3, 2019
Closed
Dev automation moved this from Needs review to Reviewer approved Dec 3, 2019
@balloob balloob merged commit eef91f8 into dev Dec 3, 2019
Dev automation moved this from Reviewer approved to Done Dec 3, 2019
@delete-merged-branch delete-merged-branch bot deleted the template-complex-leave-non-string-alone branch December 3, 2019 22:15
@lock lock bot locked and limited conversation to collaborators Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balloob @frenck @homeassistant