Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports to top for danfoss_air #29435

Merged

Conversation

springstan
Copy link
Member

Breaking Change:

Description:

Related issue (if applicable): #27284

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@probot-home-assistant probot-home-assistant bot added integration: danfoss_air small-pr PRs with less than 30 lines. labels Dec 4, 2019
@project-bot project-bot bot added this to Needs review in Dev Dec 4, 2019
Dev automation moved this from Needs review to Reviewer approved Dec 4, 2019
@MartinHjelmare MartinHjelmare merged commit a2a3c50 into home-assistant:dev Dec 4, 2019
Dev automation moved this from Reviewer approved to Done Dec 4, 2019
@springstan
Copy link
Member Author

@MartinHjelmare do you know why tests are failing for all new PRs?

@MartinHjelmare
Copy link
Member

No. Someone that knows the azure pipeline setup better needs to look at it, I think. It's not obvious.

@springstan
Copy link
Member Author

Okay thank you for informing me :)

@lock lock bot locked and limited conversation to collaborators Dec 5, 2019
@springstan springstan deleted the move-imports-danfoss-air branch December 16, 2019 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants