Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Declare dependency to pymssql #29887

Closed
wants to merge 2 commits into from
Closed

Declare dependency to pymssql #29887

wants to merge 2 commits into from

Conversation

ocalvo
Copy link
Contributor

@ocalvo ocalvo commented Dec 12, 2019

Fixes #29837

Breaking Change:

Description:

With release 0.103.0 the dependency declaration to pymssql is missing.

Related issue (if applicable): fixes #

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Dec 12, 2019
@pvizeli
Copy link
Member

pvizeli commented Dec 12, 2019

pymssql is depricated and we use now pyodbc on our images

@pvizeli pvizeli closed this Dec 12, 2019
Dev automation moved this from Needs review to Cancelled Dec 12, 2019
@ocalvo
Copy link
Contributor Author

ocalvo commented Dec 12, 2019

Is it possible to document how to migrate your configuration from mssql to odbc?

@ocalvo
Copy link
Contributor Author

ocalvo commented Dec 12, 2019

https://www.home-assistant.io/integrations/recorder/ still references mssql, so we should update the docs

@lock lock bot locked and limited conversation to collaborators Dec 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
Development

Successfully merging this pull request may close these issues.

Recorder not working with MS SQL Database
3 participants