Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update iCloud sensors when service finish its update #30680

Merged
merged 2 commits into from
Jan 11, 2020
Merged

Update iCloud sensors when service finish its update #30680

merged 2 commits into from
Jan 11, 2020

Conversation

Quentame
Copy link
Member

Breaking Change:

None

Description:

Addressed this comment : #29818 (review)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@project-bot project-bot bot added this to Needs review in Dev Jan 11, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 11, 2020
@Quentame Quentame mentioned this pull request Jan 11, 2020
Merged
8 tasks
@Quentame
Copy link
Member Author

Might be nice to be added in 0.104, right ?

MartinHjelmare
MartinHjelmare approved these changes Jan 11, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Test failure is unrelated.

Dev automation moved this from By Code Owner to Reviewer approved Jan 11, 2020
Dev automation moved this from Reviewer approved to Review in progress Jan 11, 2020
MartinHjelmare
MartinHjelmare requested changes Jan 11, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot we need to set should_poll to false in the sensor entity too.

@Quentame
Copy link
Member Author

Also forgot and add should_poll in Freebox config flow #30334

Dev automation moved this from Review in progress to Reviewer approved Jan 11, 2020
@MartinHjelmare
Copy link
Member

Test failure is unrelated.

@MartinHjelmare MartinHjelmare merged commit 519c1fa into home-assistant:dev Jan 11, 2020
Dev automation moved this from Reviewer approved to Done Jan 11, 2020
@MartinHjelmare
Copy link
Member

I don't think we need to add this to 0.104 since it's not a fix.

@lock lock bot locked and limited conversation to collaborators Jan 12, 2020
@Quentame Quentame deleted the icloud/sensor-update branch January 17, 2020 12:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: icloud small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Quentame @MartinHjelmare @homeassistant