Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add proxmoxve SSLError check and remove log spam #30818

Merged
merged 8 commits into from
Jan 28, 2020
Merged

Add proxmoxve SSLError check and remove log spam #30818

merged 8 commits into from
Jan 28, 2020

Conversation

jhollowe
Copy link
Contributor

@jhollowe jhollowe commented Jan 16, 2020

Description:

Add an exception handler for un-verified SSL certs and change dependency logger to not spam log with polling requests.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Jan 16, 2020
@probot-home-assistant probot-home-assistant bot added integration: proxmoxve small-pr PRs with less than 30 lines. labels Jan 16, 2020
@probot-home-assistant
Copy link

Hey there @k4ds3, mind taking a look at this pull request as its been labeled with a integration (proxmoxve) you are listed as a codeowner for? Thanks!

@jhollowe
Copy link
Contributor Author

Draft PR as I haven't updated the requirements everywhere.

@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Jan 16, 2020
@jhollowe jhollowe marked this pull request as ready for review January 21, 2020 04:28
@MartinHjelmare MartinHjelmare changed the title Add SSLError check and remove log spam Add proxmoxve SSLError check and remove log spam Jan 21, 2020
@MartinHjelmare MartinHjelmare moved this from Incoming to Review in progress in Dev Jan 22, 2020
Moved to proxmoxer library
Dev automation moved this from Review in progress to Reviewer approved Jan 25, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Solve the formatting by running black, and I think this is ready to merge.

Update to new version of dependency which fixes log issue
When you can't get black running, just fix whatever CI says is wrong!
@MartinHjelmare MartinHjelmare merged commit c3cef72 into home-assistant:dev Jan 28, 2020
Dev automation moved this from Reviewer approved to Done Jan 28, 2020
@lock lock bot locked and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

6 participants