Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make amcrest integration more robust #30843

Merged
merged 3 commits into from Feb 6, 2020

Commits on Jan 31, 2020

  1. Make amcrest integration more robust

    - Bump amcrest package to 1.5.6. Includes networking improvements, no longer
      communicates during Http.__init__(), and allows running snapshot command
      without using stream mode.
    - Handle login errors better, and not just at startup.
    - Increase network connect & read timeout to 6.05 seconds.
    - Increase network read timeout to 20 seconds for snapshot command.
    - Run snapshot command in separate task, that cannot be cancelled, to eliminate
      possibility of two snapshot commands running simultaneously (since
      AmcrestCam.async_camera_image can be cancelled.) Also makes sure any exceptions
      from the command are caught properly.
    pnbruckner committed Jan 31, 2020
    Copy the full SHA
    3e8d914 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2020

  1. Review change requests

    Remove leading underscore from _CannotSnapshot
    pnbruckner committed Feb 6, 2020
    Copy the full SHA
    1f7594e View commit details
    Browse the repository at this point in the history
  2. Fix lint error

    Add docstring for now public Exception class.
    pnbruckner committed Feb 6, 2020
    Copy the full SHA
    75ca755 View commit details
    Browse the repository at this point in the history