Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-synology to 0.4.0 : Add support for DSM v5 + fix sensors unknown for 15 min #31049

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Bump python-synology to 0.4.0 : Add support for DSM v5 + fix sensors unknown for 15 min #31049

merged 2 commits into from
Jan 27, 2020

Conversation

aaska
Copy link
Contributor

@aaska aaska commented Jan 21, 2020

Description:

Updated python-synology component to allow backward compatibility with Synology DSM 5.x

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: synologydsm
    host: 192.168.0.2
    port: 5001
    api_version: 5
    username: username
    password: password
    monitored_conditions:
      - disk_name
      - disk_device
      - disk_smart_status

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@springstan
Copy link
Member

@aaska please update the documentation accordingly :)

@springstan springstan changed the title Update synologydsm integration component Add support for Synology DSM v5 Jan 21, 2020
@aaska
Copy link
Contributor Author

aaska commented Jan 21, 2020

@springstan I'm a bit confused. I updated the documentation with this PR home-assistant/home-assistant.io#11833
Am I missing something ? Thank you !

@springstan
Copy link
Member

Oh I am sorry did not see that 😅 please add a link to it in your PR description.

@aaska
Copy link
Contributor Author

aaska commented Jan 21, 2020

Added the link in the description ! Sorry for the confusion :) Thank you !

@MartinHjelmare MartinHjelmare added this to Reviewer approved in Dev Jan 22, 2020
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just need a little test about the delay of the availability of the sensors on 5.2 and 6.2 before merging.

PS : I'll take care of your modifiations on my Synology DSM refactor : "Add config flow to Synology DSM" #31030, don't hesitate to take a look.

@Quentame Quentame changed the title Add support for Synology DSM v5 Bump python-synology to 0.4.0 : Add support for DSM v5 + sensors unknown for 15 min Jan 27, 2020
@Quentame Quentame self-assigned this Jan 27, 2020
@Quentame Quentame changed the title Bump python-synology to 0.4.0 : Add support for DSM v5 + sensors unknown for 15 min Bump python-synology to 0.4.0 : Add support for DSM v5 + fix sensors unknown for 15 min Jan 27, 2020
@Quentame Quentame merged commit 1f7ab90 into home-assistant:dev Jan 27, 2020
Dev automation moved this from Reviewer approved to Done Jan 27, 2020
@Quentame Quentame removed their assignment Jan 27, 2020
ManneW pushed a commit to ManneW/home-assistant that referenced this pull request Jan 28, 2020
…unknown for 15 min (home-assistant#31049)

* updating new api version

* Added new configuration option for updated API
@lock lock bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants