-
-
Notifications
You must be signed in to change notification settings - Fork 29.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-synology to 0.4.0 : Add support for DSM v5 + fix sensors unknown for 15 min #31049
Bump python-synology to 0.4.0 : Add support for DSM v5 + fix sensors unknown for 15 min #31049
Conversation
@aaska please update the documentation accordingly :) |
@springstan I'm a bit confused. I updated the documentation with this PR home-assistant/home-assistant.io#11833 |
Oh I am sorry did not see that 😅 please add a link to it in your PR description. |
Added the link in the description ! Sorry for the confusion :) Thank you ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need a little test about the delay of the availability of the sensors on 5.2 and 6.2 before merging.
PS : I'll take care of your modifiations on my Synology DSM refactor : "Add config flow to Synology DSM" #31030, don't hesitate to take a look.
…unknown for 15 min (home-assistant#31049) * updating new api version * Added new configuration option for updated API
Description:
Updated python-synology component to allow backward compatibility with Synology DSM 5.x
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: