Use config_entry.unique_id in Linky #31051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jan 23, 2020
balloob
reviewed
Jan 23, 2020
| def _show_setup_form(self, user_input=None, errors=None): | ||
| pass | ||
|
|
||
| async def _show_setup_form(self, user_input=None, errors=None): |
There was a problem hiding this comment.
It's async in adguard, icloud, twentemilieu and also not a callback (but not async) in elgato and wled.
Don't know exactly which is the best, but can fix other components if needed.
- No callback no async
- No callback async
- Callback no async
- Callback async
Getting confused, it's not homogen in the code 😅
There was a problem hiding this comment.
It's best to not define coroutines if we don't need to. There's an overhead to awaiting a coroutine compared to running a callback in the event loop.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change:
None
Description:
Use config_entry.unique_id in Linky
Checklist:
tox. Your PR cannot be merged unless tests pass