Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

UniFi integration move to push messaging #31086

Merged
merged 8 commits into from Jan 31, 2020

Conversation

@Kane610
Copy link
Member

Kane610 commented Jan 22, 2020

Proposed change

This PR moves UniFi integration from polling data during normal operations to use web socket signalling. This hopefully solves the issue where the integration seem to happen in a never ending loop requesting more data from UniFi leading to HASS being unusable.

  • Fix signalling of new clients/devices
  • Fix reconnection logic
  • Fix tests

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Additional information

  • This PR fixes or closes issue: fixes #30168

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@Kane610 Kane610 self-assigned this Jan 22, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 22, 2020
@MartinHjelmare MartinHjelmare moved this from Needs review to Incoming in Dev Jan 23, 2020
@Kane610 Kane610 marked this pull request as ready for review Jan 23, 2020
Copy link
Member

MartinHjelmare left a comment

Nice!

@MartinHjelmare MartinHjelmare moved this from Incoming to Review in progress in Dev Jan 23, 2020
Kane610 added 5 commits Jan 24, 2020
@Kane610 Kane610 added the has-tests label Jan 31, 2020
@Kane610

This comment has been minimized.

Copy link
Member Author

Kane610 commented Jan 31, 2020

@MartinHjelmare additional thoughts here?

Copy link
Member

MartinHjelmare left a comment

Looks good!

homeassistant/components/unifi/controller.py Outdated Show resolved Hide resolved
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Dev automation moved this from Review in progress to Reviewer approved Jan 31, 2020
@Kane610 Kane610 merged commit 958a867 into home-assistant:dev Jan 31, 2020
9 of 10 checks passed
9 of 10 checks passed
codecov/patch 91.66% of diff hit (target 94.58%)
Details
CI Build #20200131.50 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/project 94.63% (target 90%)
Details
Dev automation moved this from Reviewer approved to Done Jan 31, 2020
@Kane610 Kane610 deleted the Kane610:unifi-use_websockets branch Jan 31, 2020
@lock lock bot locked and limited conversation to collaborators Feb 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can鈥檛 perform that action at this time.