Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add webostv sound_output capability #31121

Merged
merged 20 commits into from
Jan 27, 2020

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Jan 23, 2020

Proposed change

Add the ability to read and set the sound_output

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

Add the ability to read and set the sound_output
@probot-home-assistant probot-home-assistant bot added integration: webostv small-pr PRs with less than 30 lines. labels Jan 23, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 23, 2020
@probot-home-assistant
Copy link

Hey there @bendavid, mind taking a look at this pull request as its been labeled with a integration (webostv) you are listed as a codeowner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title Webostv: add sound_output capability Add webostv sound_output capability Jan 23, 2020
@starkillerOG
Copy link
Contributor Author

@bendavid could you have a look at this PR and make suggestions or approve it?

@bendavid
Copy link
Contributor

This looks fine to me. If maintainers are picky about such things it might be worth squashing the commit history, but I don't have strong feelings about this myself.

Dev automation moved this from Needs review to Review in progress Jan 26, 2020
Do not have the ability to test this change right now
homeassistant/components/webostv/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/webostv/media_player.py Outdated Show resolved Hide resolved
homeassistant/components/webostv/const.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from Review in progress to Reviewer approved Jan 27, 2020
@MartinHjelmare
Copy link
Member

Test failure is unrelated. Merging.

@MartinHjelmare MartinHjelmare merged commit 1278f32 into home-assistant:dev Jan 27, 2020
Dev automation moved this from Reviewer approved to Done Jan 27, 2020
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare thanks!

@lock lock bot locked and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants