-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique IDs to automation/scenes #31150
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with a integration ( |
Not really related but this looks like a typo and possibly a bug: I was browsing the scene code and came across that. |
Fixed that. That config was never used, but I guess also never validated 馃し鈥嶁檪 Added a quick test to verify it all works. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Breaking change
Proposed change
Use the ID that the UI writes for scenes/automations
/scriptsto as the unique ID. Allows changing the entity ID.When removed via the UI, remove also from entity registry.
I've removed scripts from this PR as it requires a more elaborate approach because of the way they are configured.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: