Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Netatmo init file in test structure #31189

Merged
merged 1 commit into from
Jan 27, 2020
Merged

Add missing Netatmo init file in test structure #31189

merged 1 commit into from
Jan 27, 2020

Conversation

cyberjunky
Copy link
Contributor

Proposed change

Added missing init file, so failing CI test python37 should pass again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added has-tests small-pr PRs with less than 30 lines. labels Jan 26, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 26, 2020
@cyberjunky cyberjunky mentioned this pull request Jan 26, 2020
9 tasks
@MartinHjelmare MartinHjelmare changed the title Added missing Netatmo init file in test structure Add missing Netatmo init file in test structure Jan 26, 2020
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Jan 26, 2020
@MartinHjelmare
Copy link
Member

Test failure is unrelated. Merging.

@MartinHjelmare MartinHjelmare merged commit 50b0e93 into home-assistant:dev Jan 27, 2020
Dev automation moved this from Reviewer approved to Done Jan 27, 2020
@lock lock bot locked and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants