Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Small spacing fix for logbook.py #312

Closed
wants to merge 9 commits into from

Conversation

CCOSTAN
Copy link
Contributor

@CCOSTAN CCOSTAN commented Sep 2, 2015

First Git hub contribution ever so I'm hoping this is the correct way to do this.

Made a minor display fix for logbook.py - Added in spaces for Home Assistant started | stopped | restarted.

balloob and others added 9 commits August 24, 2015 21:45
Conflicts:
	Dockerfile
	homeassistant/components/frontend/version.py
	homeassistant/components/frontend/www_static/frontend.html
Corrected spacing for Home Assistant started|stopped|restarted
@rmkraus
Copy link
Contributor

rmkraus commented Sep 2, 2015

What is the reason that this space needs to be added? I may have missed a conversation about this.

@CCOSTAN
Copy link
Contributor Author

CCOSTAN commented Sep 2, 2015

It was just a typo. Stop and start the HA and then check the Logbook. The entries show up as 'Home Assistantstarted'.

after

@CCOSTAN CCOSTAN changed the title Patch 1 Super Small spacing fix for logbook.py Sep 2, 2015
@rmkraus
Copy link
Contributor

rmkraus commented Sep 2, 2015

You are correct, I do see that. However, even though this works, it is probably not the cleanest solution to this bug. The problem appears to actually be here in the frontend.

I hope I'm not discouraging you by shooting down your first PR! Modifying the Frontend is a bit more work than modifying other parts of the code. Paulus has written some good instructions here if you would like to give it a shot. If you don't want to mess with frontend development, please do post an issue on the home-assistant-polymer project so we can get it fixed. Thanks again.

@rmkraus rmkraus closed this Sep 2, 2015
@CCOSTAN
Copy link
Contributor Author

CCOSTAN commented Sep 2, 2015

No worries @rmkraus. Not discouraged. I figured there was probably a better way to handle the bug. The front end development is way over my head though .. Phython is a lot easier for me to read and understand. I'll open up an issue on the polymer project.

@rmkraus
Copy link
Contributor

rmkraus commented Sep 2, 2015

Oh good. Don't worry, front end development is a lot to take in at first.
Thanks for reporting.

On Wednesday, September 2, 2015, Carlo Costanzo notifications@github.com
wrote:

No worries @rmkraus https://github.com/rmkraus. Not discouraged. I
figured there was probably a better way to handle the bug. The front end
development is way over my head though .. Phython is a lot easier for me to
read and understand. I'll open up an issue on the polymer project.


Reply to this email directly or view it on GitHub
#312 (comment)
.

Thanks,

Ryan Kraus

@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants