New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Super Small spacing fix for logbook.py #312
Conversation
Conflicts: Dockerfile homeassistant/components/frontend/version.py homeassistant/components/frontend/www_static/frontend.html
Super small hotfix
Corrected spacing for Home Assistant started|stopped|restarted
What is the reason that this space needs to be added? I may have missed a conversation about this. |
You are correct, I do see that. However, even though this works, it is probably not the cleanest solution to this bug. The problem appears to actually be here in the frontend. I hope I'm not discouraging you by shooting down your first PR! Modifying the Frontend is a bit more work than modifying other parts of the code. Paulus has written some good instructions here if you would like to give it a shot. If you don't want to mess with frontend development, please do post an issue on the home-assistant-polymer project so we can get it fixed. Thanks again. |
No worries @rmkraus. Not discouraged. I figured there was probably a better way to handle the bug. The front end development is way over my head though .. Phython is a lot easier for me to read and understand. I'll open up an issue on the polymer project. |
Oh good. Don't worry, front end development is a lot to take in at first. On Wednesday, September 2, 2015, Carlo Costanzo notifications@github.com
Thanks, Ryan Kraus |
First Git hub contribution ever so I'm hoping this is the correct way to do this.
Made a minor display fix for logbook.py - Added in spaces for
Home Assistant started
| stopped | restarted.