Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing dsmr tests #31202

Merged
merged 2 commits into from
Jan 27, 2020
Merged

Disable failing dsmr tests #31202

merged 2 commits into from
Jan 27, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 27, 2020

Proposed change

Disable dsmr tests that are currently stopping our build to succeed.

The used PyCRC package is no longer available on PyPi.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added has-tests small-pr PRs with less than 30 lines. labels Jan 27, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 27, 2020
@MartinHjelmare
Copy link
Member

Should we skip the whole module?

pytest.skip(reason, allow_module_level=True)

http://doc.pytest.org/en/latest/skipping.html#skipping-test-functions

@frenck
Copy link
Member Author

frenck commented Jan 27, 2020

Doesn't matter, it will still fail.
The main issue right now is, that the test module imports the dsmr_parser module via the integration, which imports PyCRC, which is missing on PyPi.

@frenck
Copy link
Member Author

frenck commented Jan 27, 2020

  • Disabled tests in pytest as a module
  • Commented out the import from the component, to prevent it from crashing because of the missing package.
  • Disabled pylint/flake8 on the place it used the commented out import.

This all ain't pretty, but IMHO the alternative is removing it completely.

Dev automation moved this from Needs review to Reviewer approved Jan 27, 2020
@frenck frenck merged commit 050e4af into dev Jan 27, 2020
Dev automation moved this from Reviewer approved to Done Jan 27, 2020
@frenck frenck deleted the frenck-2020-0131 branch January 27, 2020 10:13
@lock lock bot locked and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants