Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain SimpliSafe's check for emergency token usage #31214

Merged
merged 1 commit into from
Jan 27, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jan 27, 2020

Proposed change

#31116 introduced functionality to use an "emergency" refresh token when SimpliSafe decides to completely invalidate both an existing access token and an existing refresh token. As implemented, the current check could invalidate that emergency refresh token before it was fully ready; this PR prevents that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
simplisafe:
  accounts:
    username: !secret simplisafe_username
    password: !secret simplisafe_password

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@bachya bachya self-assigned this Jan 27, 2020
@probot-home-assistant probot-home-assistant bot added integration: simplisafe small-pr PRs with less than 30 lines. labels Jan 27, 2020
@project-bot project-bot bot added this to Needs review in Dev Jan 27, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 27, 2020
Dev automation moved this from By Code Owner to Reviewer approved Jan 27, 2020
@bachya bachya merged commit f95a072 into home-assistant:dev Jan 27, 2020
Dev automation moved this from Reviewer approved to Done Jan 27, 2020
@bachya bachya deleted the ss-emergency-token branch January 27, 2020 17:50
@lock lock bot locked and limited conversation to collaborators Jan 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants