Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for adding a device to HomematicIP Cloud #31224

Merged
merged 3 commits into from
Jan 28, 2020
Merged

Add test for adding a device to HomematicIP Cloud #31224

merged 3 commits into from
Jan 28, 2020

Conversation

SukramJ
Copy link
Contributor

@SukramJ SukramJ commented Jan 27, 2020 •
edited
Loading

Proposed change

Add test for adding a device to HomematicIP Cloud

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jan 27, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 27, 2020
Dev automation moved this from By Code Owner to Reviewer approved Jan 28, 2020
MartinHjelmare
MartinHjelmare approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit ec2d378 into home-assistant:dev Jan 28, 2020
Dev automation moved this from Reviewer approved to Done Jan 28, 2020
@SukramJ SukramJ deleted the HmIP-add_device branch January 28, 2020 08:27
ManneW pushed a commit to ManneW/home-assistant that referenced this pull request Jan 28, 2020
@SukramJ @ManneW
Add test for adding a device to HomematicIP Cloud (home-assistant#31224)
2c49e11 
* Add test for adding a hmip device

* refactor get_mock_hap to use config_entry setup

* remove unused parameters
@lock lock bot locked and limited conversation to collaborators Jan 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: homematicip_cloud small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@SukramJ @MartinHjelmare @homeassistant