Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brefra to codeowners list Velbus integration #31245

Merged
merged 2 commits into from
Jan 28, 2020

Conversation

brefra
Copy link
Contributor

@brefra brefra commented Jan 28, 2020

Proposed change

Add myself to codeowners list

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

As suggested here

  • This PR fixes or closes issue: n/a
  • This PR is related to issue: n/a
  • Link to documentation pull request: n/a

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jan 28, 2020
@probot-home-assistant probot-home-assistant bot added integration: velbus small-pr PRs with less than 30 lines. labels Jan 28, 2020
@probot-home-assistant
Copy link

Hey there @Cereal2nd, mind taking a look at this pull request as its been labeled with a integration (velbus) you are listed as a codeowner for? Thanks!

@rytilahti
Copy link
Member

@Cereal2nd as an existing codeowner, feel free to merge it yourself :-)

@cgarwood cgarwood merged commit 03954be into home-assistant:dev Jan 28, 2020
Dev automation moved this from Needs review to Done Jan 28, 2020
ManneW pushed a commit to ManneW/home-assistant that referenced this pull request Jan 28, 2020
* Add myself to codeowners list

* Add myself to CODEOWNERS file
@brefra brefra deleted the codeowner branch January 28, 2020 18:44
@lock lock bot locked and limited conversation to collaborators Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants