Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump abodepy version to 0.17.0 #31250

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Bump abodepy version to 0.17.0 #31250

merged 1 commit into from
Jan 29, 2020

Conversation

shred86
Copy link
Contributor

@shred86 shred86 commented Jan 28, 2020 •
edited
Loading

Proposed change

Bump abodepy version to 0.17.0 which fixes #29895

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated for [www.home-assistant.io][docs-repository]

If the code communicates with devices, web services, or third-party tools:

  • The [manifest file][manifest-docs] has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following [Integration Quality Scale][quality-scale]:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Jan 28, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Jan 28, 2020
Dev automation moved this from By Code Owner to Reviewer approved Jan 29, 2020
@pvizeli pvizeli merged commit 3ae5735 into home-assistant:dev Jan 29, 2020
Dev automation moved this from Reviewer approved to Done Jan 29, 2020
@lock lock bot locked and limited conversation to collaborators Jan 30, 2020
@shred86 shred86 deleted the abode_version branch February 8, 2020 16:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed dependency integration: abode small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abode camera capture doesn't work for all Abode camera models.
3 participants
@shred86 @pvizeli @homeassistant