Add device name to sensor name for mobile_app

[dshokouhi]

Breaking change

Not a breaking change because once the entity is registered and rename this won't impact it.

Proposed change

Add the device name to the sensor name so they are easy to distinguish. Especially useful when you are logging into more than 1 device at a time because the sensor names will be like sensor.battery_level and sensor.battery_level_2. We will still hit the same issue if the device name is the same but it should help clear up some confusion about what device it is.

Fixes home-assistant/iOS#478
Fixes home-assistant/android#381

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
mobile_app:

Additional information

• This PR fixes or closes issue: fixes #Battery and wifi sensors have generic names android#381 and Ask for device name during onboarding iOS#478 and maybe others too that I have not found
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration (mobile_app) you are listed as a codeowner for? Thanks!

[dshokouhi]

CC: @balloob there was some discussion in #devs_apps about this on discord so wanted your opinion on this change too

[robbiet480]

For the name, I think the format Sensor Name (Device Name) works better too. That's a suggestion, not a directive, so i'm open to leaving it as is.

[balloob]

I think that we should Device Name Sensor Name, since we've been adding logic to strip off start of names if they match the container name. (ie Living Room area card will rename Living Room Lights -> Lights)

[balloob]

Also we have a unique ID, let the user do their thing :)

[dshokouhi]

Yup I agree we not only have unique ID but we also have the entity registered to the device so its not too difficult to find from device page. I think users are just confused by the generic name it gets when the sensor gets registered.

So the format I chose is good? Not sure if we have a official format to follow :)

[robbiet480]

What Paulus says goes, i'm fine with it.

[TomBrien]

Would also close home-assistant/iOS#478

[JBassett]

Also close home-assistant/android#381