Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling of ASUSWRT in manifest #31764

merged 2 commits into from Feb 13, 2020

Fix spelling of ASUSWRT in manifest #31764

merged 2 commits into from Feb 13, 2020


Copy link

frenck commented Feb 12, 2020

Proposed change


Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:


  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 12, 2020

Hey there @kennedyshead, mind taking a look at this pull request as its been labeled with a integration (asuswrt) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot added this to Needs review in Dev Feb 12, 2020
Copy link

springstan left a comment

Just one small comment 馃槃

homeassistant/components/asuswrt/ Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare moved this from Needs review to Review in progress in Dev Feb 13, 2020
Co-Authored-By: springstan <>
Copy link

springstan left a comment


Dev automation moved this from Review in progress to Reviewer approved Feb 13, 2020
@springstan springstan merged commit d66123c into dev Feb 13, 2020
10 checks passed
10 checks passed
CI Build #20200213.21 succeeded
CI (FullCheck Mypy) FullCheck Mypy succeeded
CI (FullCheck Pylint) FullCheck Pylint succeeded
CI (Overview CheckFormat) Overview CheckFormat succeeded
CI (Overview Lint) Overview Lint succeeded
CI (Overview Validate) Overview Validate succeeded
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 7d0b50c...a626b29
codecov/project 94.68% (target 90%)
Dev automation moved this from Reviewer approved to Done Feb 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0181 branch Feb 13, 2020
@lock lock bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.