Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename codecov so it will be picked up #31775

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Rename codecov so it will be picked up #31775

merged 1 commit into from
Feb 13, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 12, 2020

Breaking change

Proposed change

Rename .codecov.yml to codecov.yml which is the config format apparently.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Feb 12, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 12, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #31775 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #31775   +/-   ##
=======================================
  Coverage   94.66%   94.66%           
=======================================
  Files         763      763           
  Lines       55114    55114           
=======================================
  Hits        52176    52176           
  Misses       2938     2938
Impacted Files Coverage 螖
homeassistant/components/uk_transport/sensor.py 93.47% <0%> (-0.73%) 猬囷笍
homeassistant/components/tplink/light.py 96.55% <0%> (+0.57%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 834acd8...ae929ff. Read the comment docs.

@balloob
Copy link
Member Author

balloob commented Feb 13, 2020

image

Fuuuuuuuuuuuuuuu

@balloob
Copy link
Member Author

balloob commented Feb 13, 2020

Ah, from the docs:

To update this yaml, make a change, and push it to the dev branch. Alternatively, push to your yaml's strict_yaml_branch if you are using that instead. The yaml will update on Codecov during the next report upload.

@balloob balloob merged commit 52b16bf into dev Feb 13, 2020
Dev automation moved this from Needs review to Done Feb 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the rename-codecov branch February 13, 2020 00:16
@lock lock bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants