Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling: Config(uration) #31782

Merged
merged 1 commit into from Feb 13, 2020
Merged

Spelling: Config(uration) #31782

merged 1 commit into from Feb 13, 2020

Conversation

@frenck
Copy link
Member

frenck commented Feb 13, 2020

Proposed change

Removes the use of config as a word. It makes sense in a world with technical people, but configuration looks more friendly and professional.

This PR adjusts al occurrences that might be visible to the end-user.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #31782 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31782      +/-   ##
==========================================
+ Coverage   94.67%   94.68%   +<.01%     
==========================================
  Files         763      763              
  Lines       55131    55131              
==========================================
+ Hits        52196    52200       +4     
+ Misses       2935     2931       -4
Impacted Files Coverage 螖
...stant/components/homekit_controller/config_flow.py 100% <酶> (酶) 猬嗭笍
homeassistant/components/ecobee/config_flow.py 100% <酶> (酶) 猬嗭笍
homeassistant/components/uk_transport/sensor.py 94.2% <0%> (+0.72%) 猬嗭笍
homeassistant/components/template/cover.py 97.71% <0%> (+1.36%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 40e866a...285b43a. Read the comment docs.

@frenck frenck marked this pull request as ready for review Feb 13, 2020
@frenck frenck requested review from andrewsayre, Jc2k, jjlawren, Kane610 and home-assistant/core as code owners Feb 13, 2020
Copy link
Member

springstan left a comment

This is an awesome change! Another step in making HA more user friendly! 馃帀

Dev automation moved this from Needs review to Reviewer approved Feb 13, 2020
@balloob balloob merged commit 0173c61 into dev Feb 13, 2020
11 checks passed
11 checks passed
CI Build #20200213.11 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 52b16bf...285b43a
Details
codecov/project 94.68% (+<.01%) compared to 52b16bf
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 13, 2020
@delete-merged-branch delete-merged-branch bot deleted the frenck-2020-0189 branch Feb 13, 2020
@lock lock bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can鈥檛 perform that action at this time.