Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to version 2.6 of ihcsdk #31789

Merged
merged 9 commits into from
Feb 13, 2020
Merged

Update to version 2.6 of ihcsdk #31789

merged 9 commits into from
Feb 13, 2020

Conversation

dingusdk
Copy link
Contributor

Breaking change

Proposed change

The ihcsdk has been optimized to not close the connection to the IHC controller. (Keep the request session). Closing the connection could cause the controller to add delays in some cases.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: ihc small-pr PRs with less than 30 lines. labels Feb 13, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 13, 2020
@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #31789 into dev will increase coverage by 0.05%.
The diff coverage is 97.08%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31789      +/-   ##
==========================================
+ Coverage   94.62%   94.67%   +0.05%     
==========================================
  Files         739      763      +24     
  Lines       53593    55131    +1538     
==========================================
+ Hits        50710    52197    +1487     
- Misses       2883     2934      +51
Impacted Files Coverage Δ
homeassistant/components/alexa/messages.py 98.52% <ø> (ø) ⬆️
homeassistant/components/glances/const.py 100% <ø> (ø) ⬆️
...assistant/components/generic_thermostat/climate.py 94.78% <ø> (ø) ⬆️
homeassistant/components/filter/sensor.py 97.66% <ø> (ø) ⬆️
homeassistant/components/emulated_roku/binding.py 91.17% <ø> (ø) ⬆️
homeassistant/bootstrap.py 72.61% <ø> (ø) ⬆️
homeassistant/auth/mfa_modules/notify.py 91.12% <ø> (ø) ⬆️
...omeassistant/components/cert_expiry/config_flow.py 98.36% <ø> (ø) ⬆️
homeassistant/components/apns/notify.py 96.94% <ø> (ø) ⬆️
homeassistant/components/deconz/light.py 96.52% <100%> (+0.03%) ⬆️
... and 161 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f303a54...dedec2d. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 13, 2020
@springstan springstan merged commit 8356ea2 into home-assistant:dev Feb 13, 2020
Dev automation moved this from Reviewer approved to Done Feb 13, 2020
@lock lock bot locked and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants