Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Home Assistant Companion to manifest.json so we can suggest the app to the user #31808

Merged
merged 1 commit into from Feb 13, 2020

Conversation

@robbiet480
Copy link
Member

robbiet480 commented Feb 13, 2020

First half of the work required to enable prompting Android users to install HAC. As per instructions found here.

Related: home-assistant/frontend#4312

…pp to the user
@probot-home-assistant

This comment has been minimized.

Copy link

probot-home-assistant bot commented Feb 13, 2020

Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with a integration (frontend) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Feb 13, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #31808 into dev will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31808      +/-   ##
==========================================
- Coverage   94.67%   94.67%   -0.01%     
==========================================
  Files         763      763              
  Lines       55131    55148      +17     
==========================================
+ Hits        52196    52212      +16     
- Misses       2935     2936       +1     
Impacted Files Coverage Δ
homeassistant/helpers/config_validation.py 95.66% <0.00%> (-0.40%) ⬇️
homeassistant/components/ps4/media_player.py 89.76% <0.00%> (-0.16%) ⬇️
homeassistant/components/teksavvy/sensor.py 97.77% <0.00%> (-0.03%) ⬇️
homeassistant/components/startca/sensor.py 97.95% <0.00%> (-0.03%) ⬇️
homeassistant/components/wled/const.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/fido/sensor.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/wled/sensor.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/simplisafe/const.py 100.00% <0.00%> (ø) ⬆️
homeassistant/helpers/entity.py 97.61% <0.00%> (+0.01%) ⬆️
homeassistant/components/uk_transport/sensor.py 94.20% <0.00%> (+0.72%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40e866a...1f7169f. Read the comment docs.

@robbiet480 robbiet480 merged commit f6341ed into home-assistant:dev Feb 13, 2020
11 checks passed
11 checks passed
CI Build #20200213.80 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing 52b16bf...1f7169f
Details
codecov/project 94.67% (target 90.00%)
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 13, 2020
@robbiet480 robbiet480 deleted the robbiet480:suggest-android-app branch Feb 13, 2020
@lock lock bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.