Speed up tests of HomematicIP Cloud #31810
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
balloob
reviewed
Feb 14, 2020
|
|
||
| def init_home(self, json_path=HOME_JSON): | ||
| """Init template with json.""" | ||
| self.init_json_state = json.loads(load_fixture(HOME_JSON)) | ||
| self.init_json_state = self._cleanup_json(json.loads(load_fixture(HOME_JSON))) |
There was a problem hiding this comment.
So I don't think json_path is ever used in init_home and so it's always the same fixture. I think that it could help in loading the fixture once instead of every test. I would still do json.loads on each test in case the original data is mutated.
# Put on top of file.
FIXTURE_DATA = load_fixture(HOME_JSON)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR speeds up the execution of the HomematicIP Cloud tests by filtering out not required devices or groups from origin test data json.
Besides some required renaming this PR adds a factory to create a HomematicIP Access Point.
This Factory expects a list of device/group names to just create these and not all available devices.
As a result the tests are executed in 11 seconds instead of 60 seconds before. (on my machine)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: