Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Significantly reduce code in august integration #32030

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 20, 2020

Breaking change

Proposed change

  • Activity updates can now be processed by py-august
    this allows us to eliminate the activity sync
    code for the door sensors and locks

  • Lock and door state can now be consumed from
    the lock detail api which allows us to
    remove the status call apis and reduce
    the number of API calls to august

  • Refactor the testing method for locks (part Unresolved TODO in /homeassistant/components/httpinterface/__init__.py : 575 #1) -- more in the next PRs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

* Activity updates can now be processed by py-august
  this allows us to eliminate the activity sync
  code for the door sensors and locks

* Lock and door state can now be consumed from
  the lock detail api which allows us to
  remove the status call apis and reduce
  the number of API calls to august

* Refactor the testing method for locks (part #1)
@project-bot project-bot bot added this to Needs review in Dev Feb 20, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 20, 2020
@codecov
Copy link

codecov bot commented Feb 20, 2020

Codecov Report

❗ No coverage uploaded for pull request base (dev@6c9d4a6). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##             dev   #32030   +/-   ##
======================================
  Coverage       ?   94.71%           
======================================
  Files          ?      766           
  Lines          ?    55568           
  Branches       ?        0           
======================================
  Hits           ?    52630           
  Misses         ?     2938           
  Partials       ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9d4a6...00c1281. Read the comment docs.

Dev automation moved this from By Code Owner to Reviewer approved Feb 21, 2020
@balloob balloob merged commit d4075fb into home-assistant:dev Feb 21, 2020
Dev automation moved this from Reviewer approved to Done Feb 21, 2020
@lock lock bot locked and limited conversation to collaborators Feb 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants