Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zwave climate fix and wink cover. #3205

Merged
merged 6 commits into from
Sep 7, 2016
Merged

Zwave climate fix and wink cover. #3205

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c9ab822
Fixes setpoint get was done outside loop
turbokongen Sep 5, 2016
e30d751
zxt_120
turbokongen Sep 5, 2016
d405db4
Wink not migrated to cover
turbokongen Sep 5, 2016
a60dfa2
Clarifying debug
turbokongen Sep 5, 2016
1790b95
too long line
turbokongen Sep 5, 2016
80a82ef
Only add 1 device entity
turbokongen Sep 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 10 additions & 0 deletions homeassistant/components/climate/zwave.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,16 @@ def update_properties(self):
continue
if self._zxt_120:
continue
self._target_temperature = int(value.data)
_LOGGER.debug("Setpoint get SET_TEMP_TO_INDEX=%s and"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clarify (see below)

" self._current_operation=%s",
SET_TEMP_TO_INDEX.get(self._current_operation),
self._current_operation)
break
_LOGGER.debug("Setpoint get not matching SET_TEMP_TO_INDEX=%s and"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think you can clarify this debug line? Not sure what exactly setpoint get not means.

" self._current_operation=%s. Using value.data=%s",
SET_TEMP_TO_INDEX.get(self._current_operation),
self._current_operation, int(value.data))
self._target_temperature = int(value.data)

@property
Expand Down
4 changes: 2 additions & 2 deletions homeassistant/components/wink.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,8 @@ def setup(hass, config):
('binary_sensor', pywink.get_sensors),
('sensor', lambda: pywink.get_sensors or pywink.get_eggtrays),
('lock', pywink.get_locks),
('rollershutter', pywink.get_shades),
('garage_door', pywink.get_garage_doors)):
('cover', pywink.get_shades),
('cover', pywink.get_garage_doors)):

if func_exists():
discovery.load_platform(hass, component_name, DOMAIN, {}, config)
Expand Down