Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky coverage in UK transport test #32053

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Fix flaky coverage in UK transport test #32053

merged 1 commit into from
Feb 25, 2020

Conversation

balloob
Copy link
Member

@balloob balloob commented Feb 21, 2020

Breaking change

Proposed change

Based on time of day this test would hit/not-hit a single line. This test sets the time to fixed value so it always hits that line.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added has-tests small-pr PRs with less than 30 lines. labels Feb 21, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 21, 2020
@codecov
Copy link

codecov bot commented Feb 21, 2020

Codecov Report

Merging #32053 into dev will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32053   +/-   ##
=======================================
  Coverage   94.71%   94.71%           
=======================================
  Files         766      766           
  Lines       55568    55568           
=======================================
  Hits        52630    52630           
  Misses       2938     2938           

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 6e74ee7...e945a9b. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 21, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@MartinHjelmare
Copy link
Member

Do we need to patch the bus test too?

@balloob
Copy link
Member Author

balloob commented Feb 25, 2020

Nah, we just need to hit the time adjustment code once, it's shared.

@balloob balloob merged commit 5776b9f into dev Feb 25, 2020
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@balloob balloob deleted the fix-flaky-coverage branch February 25, 2020 05:27
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed has-tests small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants