Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Config flow to august #32133

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 24, 2020

Breaking change

Proposed change

Convert august to config flow

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@project-bot project-bot bot added this to Needs review in Dev Feb 24, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 24, 2020
@bdraco
Copy link
Member Author

bdraco commented Feb 24, 2020

This is on top of #32125

@bdraco bdraco force-pushed the august_config_flow_ontop_of_battery_sensors branch from 5755388 to 741049f Compare February 24, 2020 06:43
@bdraco bdraco force-pushed the august_config_flow_ontop_of_battery_sensors branch 2 times, most recently from feeb808 to f09f696 Compare February 24, 2020 08:48
@bdraco bdraco force-pushed the august_config_flow_ontop_of_battery_sensors branch from f09f696 to 11f1ca9 Compare February 24, 2020 09:22
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #32133 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32133      +/-   ##
==========================================
+ Coverage   94.74%   94.75%   +0.01%     
==========================================
  Files         767      768       +1     
  Lines       55498    55644     +146     
==========================================
+ Hits        52581    52727     +146     
  Misses       2917     2917
Impacted Files Coverage Δ
homeassistant/generated/config_flows.py 100% <ø> (ø) ⬆️
homeassistant/util/dt.py 95.36% <0%> (-4.12%) ⬇️
...meassistant/components/mqtt/vacuum/schema_state.py 91.13% <0%> (-0.59%) ⬇️
...istant/components/homekit_controller/connection.py 92.73% <0%> (-0.09%) ⬇️
homeassistant/components/buienradar/camera.py 96.34% <0%> (-0.05%) ⬇️
homeassistant/components/twitch/sensor.py 96.7% <0%> (-0.04%) ⬇️
homeassistant/components/demo/media_player.py 95.67% <0%> (-0.03%) ⬇️
homeassistant/components/device_tracker/legacy.py 99.14% <0%> (-0.01%) ⬇️
homeassistant/components/rflink/light.py 100% <0%> (ø) ⬆️
homeassistant/components/darksky/sensor.py 96.81% <0%> (ø) ⬆️
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 693441e...4fc3a03. Read the comment docs.

@springstan springstan changed the title Config flow for august Add Config flow to august Feb 24, 2020
bdraco and others added 2 commits February 24, 2020 20:34
Co-Authored-By: Paulus Schoutsen <paulus@home-assistant.io>
…com:bdraco/home-assistant into august_config_flow_ontop_of_battery_sensors
Copy link
Member Author

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That should resolve all review comments

Dev automation moved this from By Code Owner to Reviewer approved Feb 25, 2020
@balloob balloob merged commit 2925e06 into home-assistant:dev Feb 25, 2020
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants