Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SimpliSafe entities unavailable when wifi is lost #32154

Merged
merged 4 commits into from
Feb 26, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Feb 24, 2020

Proposed change

This PR updates the SimpliSafe integration to watch for loss (and restoration) of wifi connection to the base station; upon seeing these events, SimpliSafe entities are marked/unmarked unavailable. Additionally, the PR removes checking online/offline status via the REST API (since the above events now do the same job).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
simplisafe:
  accounts:
    - username: !secret simplisafe_username
      password: !secret simplisafe_password

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bachya bachya self-assigned this Feb 24, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 24, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 24, 2020
@codecov
Copy link

codecov bot commented Feb 24, 2020

Codecov Report

Merging #32154 into dev will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32154      +/-   ##
==========================================
+ Coverage   94.73%   94.74%   +0.01%     
==========================================
  Files         767      772       +5     
  Lines       55486    55864     +378     
==========================================
+ Hits        52562    52931     +369     
- Misses       2924     2933       +9
Impacted Files Coverage Δ
...istant/components/google_assistant/report_state.py 83.33% <0%> (-1.67%) ⬇️
homeassistant/components/alexa/state_report.py 83.63% <0%> (-0.63%) ⬇️
...meassistant/components/mqtt/vacuum/schema_state.py 91.13% <0%> (-0.59%) ⬇️
homeassistant/components/twitch/sensor.py 96.7% <0%> (-0.04%) ⬇️
homeassistant/components/rflink/light.py 100% <0%> (ø) ⬆️
homeassistant/components/darksky/sensor.py 96.81% <0%> (ø) ⬆️
homeassistant/components/mqtt/fan.py 97.96% <0%> (ø) ⬆️
homeassistant/components/withings/const.py 100% <0%> (ø) ⬆️
homeassistant/components/mqtt/binary_sensor.py 100% <0%> (ø) ⬆️
homeassistant/components/almond/config_flow.py 100% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90859b8...ca55618. Read the comment docs.

@bachya bachya merged commit b5c1afc into home-assistant:dev Feb 26, 2020
Dev automation moved this from By Code Owner to Done Feb 26, 2020
@bachya bachya deleted the ss-wifi-lost branch February 26, 2020 03:03
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants