Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize Ambient PWS config flow #32164

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Feb 25, 2020

Proposed change

This PR modernizes the Ambient PWS config flow:

  • Removes configured_instances usage (no longer needed)
  • Uses built-in unique ID and abort helpers (instead of custom logic)
  • Registers the domain upon config flow definition

Additionally, this PR bumps aioambient to 1.0.4.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
ambient_station:
  api_key: !secret ambient_api_key
  app_key: !secret ambient_app_key

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@bachya bachya self-assigned this Feb 25, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 25, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32164 into dev will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32164      +/-   ##
==========================================
- Coverage   94.74%   94.73%   -0.01%     
==========================================
  Files         767      768       +1     
  Lines       55621    55613       -8     
==========================================
- Hits        52696    52687       -9     
- Misses       2925     2926       +1     
Impacted Files Coverage Δ
homeassistant/components/uk_transport/sensor.py 93.47% <0.00%> (-0.73%) ⬇️
homeassistant/components/twitch/sensor.py 96.70% <0.00%> (-0.04%) ⬇️
homeassistant/util/yaml/loader.py 93.58% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/fan.py 97.96% <0.00%> (ø) ⬆️
homeassistant/components/file/notify.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/gdacs/const.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/switch.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/awair/sensor.py 95.09% <0.00%> (ø) ⬆️
homeassistant/components/mhz19/sensor.py 95.06% <0.00%> (ø) ⬆️
homeassistant/components/rflink/light.py 100.00% <0.00%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2d7bc4...40b37d7. Read the comment docs.

Dev automation moved this from By Code Owner to Reviewer approved Feb 25, 2020
@balloob balloob merged commit ba4cc37 into home-assistant:dev Feb 25, 2020
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@bachya bachya deleted the ambient-config-update branch February 25, 2020 15:47
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants