Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing device class attributes to homekit_controller sensors #32175

Merged

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Feb 25, 2020

Proposed change

I recently switched from using the Hue integration to control my Hue lights to using homekit_controller so that I had more devices to test with. It flushed out that a temperature sensor wasn't marked as a temperature sensor so the other homekit integration couldn't re-export it to my phone any more.

This adds a bunch of missing device_class attributes to homekit_controller sensors.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Feb 25, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32175 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #32175   +/-   ##
=======================================
  Coverage   94.75%   94.75%           
=======================================
  Files         768      768           
  Lines       55639    55650   +11     
=======================================
+ Hits        52721    52733   +12     
+ Misses       2918     2917    -1     
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.64% <0.00%> (+0.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 438c4ac...be12417. Read the comment docs.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Feb 25, 2020
@MartinHjelmare MartinHjelmare merged commit dd13e99 into home-assistant:dev Feb 25, 2020
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@Jc2k Jc2k deleted the homekit_controller_device_class branch February 26, 2020 14:18
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants