-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-tado to 0.3.0 #32186
Bump python-tado to 0.3.0 #32186
Conversation
Is it possible for this to be included in the beta or next release? The only impacted change is the addition of a timeout, the other functions are not used. Changelog: wmalgadey/PyTado@0.2.9...0.3.0 |
Codecov Report
@@ Coverage Diff @@
## dev #32186 +/- ##
==========================================
+ Coverage 94.74% 94.74% +<.01%
==========================================
Files 772 772
Lines 55864 55864
==========================================
+ Hits 52930 52931 +1
+ Misses 2934 2933 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✌
I would think so yes, because it is a hotfix that solves a major issue and does not introduce any new features. Therefore, I am going to tag it for beta/the next release. |
Proposed change
Bump python-tado to 0.3.0
This fixes a possible unlimited timeout that could cause Home Assistant to lock up.
See #30507 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: