Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-tado to 0.3.0 #32186

Merged
merged 1 commit into from Feb 25, 2020
Merged

Conversation

@michaelarnauts
Copy link
Contributor

michaelarnauts commented Feb 25, 2020

Proposed change

Bump python-tado to 0.3.0
This fixes a possible unlimited timeout that could cause Home Assistant to lock up.

See #30507 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #30507
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
@project-bot project-bot bot added this to Needs review in Dev Feb 25, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 25, 2020
@michaelarnauts

This comment has been minimized.

Copy link
Contributor Author

michaelarnauts commented Feb 25, 2020

Is it possible for this to be included in the beta or next release? The only impacted change is the addition of a timeout, the other functions are not used.

Changelog: wmalgadey/PyTado@0.2.9...0.3.0

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32186 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32186      +/-   ##
==========================================
+ Coverage   94.74%   94.74%   +<.01%     
==========================================
  Files         772      772              
  Lines       55864    55864              
==========================================
+ Hits        52930    52931       +1     
+ Misses       2934     2933       -1
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.64% <0%> (+0.33%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ceb3985...99ba9a3. Read the comment docs.

Copy link
Member

springstan left a comment

LGTM 鉁

Dev automation moved this from By Code Owner to Reviewer approved Feb 25, 2020
@springstan

This comment has been minimized.

Copy link
Member

springstan commented Feb 25, 2020

Is it possible for this to be included in the beta or next release? The only impacted change is the addition of a timeout, the other functions are not used.

Changelog: wmalgadey/PyTado@0.2.9...0.3.0

I would think so yes, because it is a hotfix that solves a major issue and does not introduce any new features. Therefore, I am going to tag it for beta/the next release.

@springstan springstan added this to the 0.106.0 milestone Feb 25, 2020
@springstan springstan merged commit 24652d8 into home-assistant:dev Feb 25, 2020
11 checks passed
11 checks passed
CI Build #20200225.121 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing ceb3985...99ba9a3
Details
codecov/project 94.74% (+<.01%) compared to ceb3985
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
balloob added a commit that referenced this pull request Feb 25, 2020
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.