Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump socialbladeclient to 0.5 #32191

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Bump socialbladeclient to 0.5 #32191

merged 1 commit into from
Feb 25, 2020

Conversation

pinkywafer
Copy link
Contributor

Updates socialbladeclient to 0.5 to address Unable to find valid channel ID issue

Proposed change

Update socialbladeclient to 0.5 to address Unable to find valid channel ID issue

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

Updates socialbladeclient to address `Unable to find valid channel ID` issue
closes #31683
@homeassistant
Copy link
Contributor

Hi @pinkywafer,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Dev automation moved this from Needs review to Reviewer approved Feb 25, 2020
@springstan springstan changed the title Update socialbladeclient Bump socialbladeclient to 0.5 Feb 25, 2020
@springstan
Copy link
Member

@pinkywafer should we include this in 0.106?

@springstan springstan merged commit 1f23361 into home-assistant:dev Feb 25, 2020
Dev automation moved this from Reviewer approved to Done Feb 25, 2020
@pinkywafer
Copy link
Contributor Author

As soon as possible, as the integration is currently not working due to api changes

@springstan
Copy link
Member

Sure, sounds good to me.

@springstan springstan added this to the 0.106.0 milestone Feb 25, 2020
@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32191 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32191      +/-   ##
==========================================
+ Coverage   94.74%   94.75%   +<.01%     
==========================================
  Files         772      772              
  Lines       55864    55872       +8     
==========================================
+ Hits        52930    52939       +9     
+ Misses       2934     2933       -1
Impacted Files Coverage Δ
homeassistant/util/json.py 85.5% <0%> (-0.21%) ⬇️
homeassistant/components/recorder/models.py 93.87% <0%> (-0.07%) ⬇️
homeassistant/helpers/aiohttp_client.py 95.29% <0%> (-0.06%) ⬇️
...eassistant/components/homekit_controller/sensor.py 100% <0%> (ø) ⬆️
...ant/components/homekit_controller/binary_sensor.py 100% <0%> (ø) ⬆️
homeassistant/helpers/entity.py 97.64% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ceb3985...6bfeb78. Read the comment docs.

balloob pushed a commit that referenced this pull request Feb 25, 2020
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Socialblade integration not working
4 participants