-
-
Notifications
You must be signed in to change notification settings - Fork 28.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce August doorbell detail updates #32193
Reduce August doorbell detail updates #32193
Conversation
* Doorbell images now get updates from the activity feed * Tests for activity updates * py-august now provides bridge_is_online for available state * py-august now provides is_standby for available state * py-august now provides get_doorbell_image (eliminate requests)
@MartinHjelmare This resolves the camera image fetch issue happening outside of py-august noted in #32044 |
Codecov Report
@@ Coverage Diff @@
## dev #32193 +/- ##
==========================================
+ Coverage 94.74% 94.75% +<.01%
==========================================
Files 772 772
Lines 55885 55885
==========================================
+ Hits 52951 52952 +1
+ Misses 2934 2933 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
I think that this PR (or one of the other recent August PRs) have introduced a flaky test:
|
@balloob There is a race condition here where the activity doesn't get streamed in soon enough. I think this should be fixed in #32197 Ideally this would block until the activity update is done, but I鈥檓 not exactly sure how to instrument that without mocking the internals |
Breaking change
Proposed change
Reduce August doorbell detail updates
Doorbell images now get updates from the activity feed
Tests for activity updates
py-august now provides bridge_is_online for available state
py-august now provides is_standby for available state
py-august now provides get_doorbell_image (eliminate requests)
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: