Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedreader reduce log level #32244

Merged
merged 1 commit into from Feb 28, 2020

Conversation

exxamalte
Copy link
Contributor

@exxamalte exxamalte commented Feb 27, 2020

Proposed change

There are some cases where the initial strict parsing approach of the integration fails (like mismatch of character encoding), but the feed entries could still be extracted successfully.

I am proposing to reduce log level of message from ERROR to WARNING in this case.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
feedreader:
  urls:
    - https://www.gdacs.org/xml/rss.xml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant bot added integration: feedreader small-pr PRs with less than 30 lines. labels Feb 27, 2020
@project-bot project-bot bot added this to Needs review in Dev Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

Merging #32244 into dev will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##              dev   #32244    +/-   ##
========================================
  Coverage   94.74%   94.74%            
========================================
  Files         768      772     +4     
  Lines       55629    55929   +300     
========================================
+ Hits        52703    52991   +288     
- Misses       2926     2938    +12     
Impacted Files Coverage Δ
homeassistant/helpers/debounce.py 91.07% <0.00%> (-3.81%) ⬇️
...istant/components/google_assistant/report_state.py 83.33% <0.00%> (-1.67%) ⬇️
homeassistant/components/alexa/state_report.py 83.63% <0.00%> (-0.63%) ⬇️
...meassistant/components/mqtt/vacuum/schema_state.py 91.13% <0.00%> (-0.59%) ⬇️
homeassistant/components/twitch/sensor.py 96.70% <0.00%> (-0.04%) ⬇️
homeassistant/components/mqtt/fan.py 97.96% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/lock.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/mqtt/const.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/file/notify.py 100.00% <0.00%> (ø) ⬆️
homeassistant/components/gdacs/const.py 100.00% <0.00%> (ø) ⬆️
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b2544c...3cc574d. Read the comment docs.

Dev automation moved this from Needs review to Reviewer approved Feb 28, 2020
@pvizeli pvizeli merged commit 6852ccd into home-assistant:dev Feb 28, 2020
Dev automation moved this from Reviewer approved to Done Feb 28, 2020
@exxamalte exxamalte deleted the feedreader-log-message branch February 28, 2020 14:46
@lock lock bot locked and limited conversation to collaborators Mar 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Feedreader error on us-ascii/utf-8
3 participants