New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix monitored_conditions bug #32666
Fix monitored_conditions bug #32666
Conversation
@@ -46,6 +47,9 @@ | |||
vol.Required(CONF_IP_ADDRESS): cv.string, | |||
vol.Required(CONF_CLOUD_ID): cv.string, | |||
vol.Required(CONF_INSTALL_CODE): cv.string, | |||
vol.Optional(CONF_MONITORED_CONDITIONS, default=list(SENSORS)): vol.All( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a constant for list(SENSORS)
named DEFAULT_MONITORED_CONDITIONS
@@ -46,6 +47,9 @@ | |||
vol.Required(CONF_IP_ADDRESS): cv.string, | |||
vol.Required(CONF_CLOUD_ID): cv.string, | |||
vol.Required(CONF_INSTALL_CODE): cv.string, | |||
vol.Optional(CONF_MONITORED_CONDITIONS, default=list(SENSORS)): vol.All( | |||
cv.ensure_list, [vol.In(list(SENSORS))] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You do not need the list()
here
cv.ensure_list, [vol.In(list(SENSORS))] | |
cv.ensure_list, [vol.In(SENSORS)] |
@@ -83,7 +87,7 @@ def setup_platform(hass, config, add_entities, discovery_info=None): | |||
|
|||
eagle_data = EagleData(eagle_reader) | |||
eagle_data.update() | |||
monitored_conditions = list(SENSORS) | |||
monitored_conditions = config[CONF_MONITORED_CONDITIONS] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move this up to the other local variables that store config values e.g. line 81.
Monitored conditions is being phased out. See ADR-003 |
Proposed change
The sensor code did not let the user pick which conditions that were to be monitored. By default all conditions were monitored.
This change correctly implements the
monitored_conditions
so they user can optionally pick and choose what they want to monitor.Bumping API version to resolve Unknown value for monitored conditions, if device does not collect the data.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: