New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update vizio app_id state attribute to show app config dict instead of app name #32727
Merged
balloob
merged 6 commits into
home-assistant:dev
from
raman325:vizio_app_config_attribute
Mar 25, 2020
Merged
Update vizio app_id state attribute to show app config dict instead of app name #32727
balloob
merged 6 commits into
home-assistant:dev
from
raman325:vizio_app_config_attribute
Mar 25, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: vizio
small-pr
PRs with less than 30 lines.
labels
Mar 12, 2020
Merged
7 tasks
raman325
changed the title
Add device_state_attributes to vizio to show app_config when app name can't be determined
Update vizio app_id to show id dict
Mar 13, 2020
raman325
changed the title
Update vizio app_id to show id dict
Update vizio app_id to show app config dict
Mar 13, 2020
raman325
changed the title
Update vizio app_id to show app config dict
Update vizio app_id state attribute to show app config dict instead of app name
Mar 13, 2020
… generation. squashed from multiple commits to make a rebase on dev easier
raman325
force-pushed
the
vizio_app_config_attribute
branch
from
March 23, 2020 00:41
2e5dbeb
to
4f17878
Compare
Per @MartinHjelmare 's feedback on #33051 I will be submitting a separate PR to remove the conditional logic out of my test helpers. So when reviewing this PR please ignore that issue for now, as it will require significant changes and will be easier to submit and review separately. |
20 tasks
balloob
reviewed
Mar 24, 2020
balloob
approved these changes
Mar 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR updates the
app_id
state attribute to show the config properties needed to identify an app. It is possible for the user to manually configure the app for detection in HA (when pyvizio can’t detect the app name natively) using the configuration provided by the Vizio API, but this previously required users to install and runpyvizio
locally whereas now users can get this information from Home Assistant directly.I'm also reducing the number of calls to the Vizio API from 2 to 1 by simplifying the logic to retrieve the app name
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: