Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle unique WLED device using zeroconf properties #32897

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 17, 2020

Proposed change

WLED now sends out a unique identifier (mac address) in the latest firmware.
This PR leverages that, by using that mac address in the zeroconf properties if it is available. If the property is missing, it will fallback and query the device like before.

This is an improvement since HA does not need to connect to the device during discovery (on each start).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@project-bot project-bot bot added this to Needs review in Dev Mar 17, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 17, 2020
@frenck frenck changed the title Handle unique WLED device using zeroconf properies Handle unique WLED device using zeroconf properties Mar 17, 2020
@frenck frenck force-pushed the frenck-2020-0298 branch 2 times, most recently from 4d33c0d to 24cb1c8 Compare March 17, 2020 13:44
Dev automation moved this from By Code Owner to Reviewer approved Mar 18, 2020
@frenck frenck merged commit 4517f0d into dev Mar 18, 2020
Dev automation moved this from Reviewer approved to Done Mar 18, 2020
@frenck frenck deleted the frenck-2020-0298 branch March 18, 2020 10:10
@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants