Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add device automation as frontend dependency #32962

Merged
merged 1 commit into from Mar 19, 2020
Merged

Conversation

balloob
Copy link
Member

@balloob balloob commented Mar 19, 2020

Breaking change

Proposed change

Add device automation as dependency to the frontend because we rely on the API to be available.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@project-bot project-bot bot added this to Needs review in Dev Mar 19, 2020
@balloob balloob added this to the 0.107.1 milestone Mar 19, 2020
@probot-home-assistant
Copy link

Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with a integration (frontend) you are listed as a codeowner for? Thanks!

Dev automation moved this from Needs review to Reviewer approved Mar 19, 2020
@balloob balloob merged commit 08aa4b0 into dev Mar 19, 2020
Dev automation moved this from Reviewer approved to Done Mar 19, 2020
@balloob balloob deleted the fix-device-automation-api branch March 19, 2020 01:15
@balloob balloob mentioned this pull request Mar 19, 2020
austinmroczek added a commit to austinmroczek/home-assistant that referenced this pull request Mar 21, 2020
@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants