Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sighthound dependency issue #33010

Merged
merged 1 commit into from Mar 19, 2020
Merged

Fix sighthound dependency issue #33010

merged 1 commit into from Mar 19, 2020

Conversation

robmarkcole
Copy link
Contributor

Proposed change

Fix #32989 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@project-bot project-bot bot added this to Needs review in Dev Mar 19, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 19, 2020
robmarkcole
robmarkcole commented Mar 19, 2020
View reviewed changes
requirements_test_all.txt
# homeassistant.components.sighthound
# homeassistant.components.tensorflow
pillow==7.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This addition was created by running gen_requirements_all.py

@robmarkcole robmarkcole changed the title adds pillow Fix sighthound dependency issue Mar 19, 2020
@frenck frenck added this to the 0.107.2 milestone Mar 19, 2020
Dev automation moved this from By Code Owner to Reviewer approved Mar 19, 2020
frenck
frenck approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @robmarkcole! 👍
Tagged it for 0.107.2

@frenck frenck merged commit 9451920 into home-assistant:dev Mar 19, 2020
Dev automation moved this from Reviewer approved to Done Mar 19, 2020
balloob pushed a commit that referenced this pull request Mar 20, 2020
@robmarkcole @balloob
Fix sighthound dependency issue (#33010)
346a4b3
@balloob balloob mentioned this pull request Mar 20, 2020
Merged
@lock lock bot locked and limited conversation to collaborators Mar 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency integration: sighthound small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Milestone
0.107.2
Development

Successfully merging this pull request may close these issues.

Sighthound Component Missing in 0.107
5 participants
@robmarkcole @frenck @MartinHjelmare @balloob @homeassistant