Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ONVIF camera snapshot with auth #33241

Merged
merged 1 commit into from Mar 25, 2020
Merged

Fix ONVIF camera snapshot with auth #33241

merged 1 commit into from Mar 25, 2020

Conversation

frenck
Copy link
Member

@frenck frenck commented Mar 25, 2020

Proposed change

Fixes ONVIF snapshot URI support added in #33149, when the camera uses authentication.

ONVIF cameras use HTTP Digest auth, which is not supported by aiohttp.
Simplified auth handling and fallback to ffmpeg handling in general.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
camera:
  - platform: onvif
    host: 192.168.1.2
    port: 8000
    profile: 1
    username: admin
    password: password

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added integration: onvif small-pr PRs with less than 30 lines. labels Mar 25, 2020
@project-bot project-bot bot added this to Needs review in Dev Mar 25, 2020
Dev automation moved this from Needs review to Reviewer approved Mar 25, 2020
@frenck frenck merged commit 1fa996e into dev Mar 25, 2020
Dev automation moved this from Reviewer approved to Done Mar 25, 2020
@frenck frenck deleted the frenck-2020-0324 branch March 25, 2020 12:32
@lock lock bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants