Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

plexwebsocket bump 0.0.7 to fix ignored tests #33398

Merged
merged 2 commits into from Mar 29, 2020

Conversation

jjlawren
Copy link
Contributor

@jjlawren jjlawren commented Mar 29, 2020

Proposed change

Uncaught exceptions were in found in the plexwebsocket dependency by #33312. This PR adds a small guard in the dependency and clears the ignored exceptions.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added core integration: plex small-pr PRs with less than 30 lines. labels Mar 29, 2020
@project-bot project-bot bot added this to Needs review in Dev Mar 29, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Mar 29, 2020
Copy link
Contributor

@dmulcahey dmulcahey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go when CI passes

Dev automation moved this from By Code Owner to Reviewer approved Mar 29, 2020
@dmulcahey dmulcahey merged commit ffafcf2 into home-assistant:dev Mar 29, 2020
Dev automation moved this from Reviewer approved to Done Mar 29, 2020
@jjlawren jjlawren deleted the plexwebsocket_bump_0.0.7 branch March 29, 2020 16:15
@springstan springstan mentioned this pull request Mar 30, 2020
@lock lock bot locked and limited conversation to collaborators Apr 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Fix plex tests that have uncaught exceptions
3 participants