New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Purge recorder database at night #33646
Conversation
4:12 is a great choice. 馃憤 Should we document this? |
I couldn't quite decide that. I kept it out of the documentation for now to give us some leeway for tweaks but I will go with whatever people want. |
This comment has been minimized.
This comment has been minimized.
@BudBundi use |
@amelchio I put some suggested language in the docs PR. |
): cv.positive_int, | ||
} | ||
vol.Optional(DOMAIN, default=dict): vol.All( | ||
cv.deprecated(CONF_PURGE_INTERVAL, invalidation_version="0.111.0"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's drop the invalidation_version
. Let it be a warning and we can drop it at some point in the future. No reason to break things if we can keep it as a warning and it's not impacting operation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Thank you for reviewing!
Should we label this a breaking change? |
Yeah, sorry. I put the text in but I always forget about the label 馃檮 |
Breaking change
recorder
configurationpurge_interval
has been deprecated. The recorder database is now purged every night. This can be disabled with the newauto_purge
configuration though that is usually not recommended.Proposed change
This updates the recorder purge schedule as discussed in home-assistant/architecture#358.
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: