Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure SimpliSafe state sync when websocket falters #33680

Merged
merged 1 commit into from Apr 5, 2020

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Apr 5, 2020

Proposed change

Despite simplisafe-python having a watchdog in place, it's possible that the SimpliSafe Cloud websocket will fail to return events from time to time (for who knows what reason). This PR updates the integration so that the state is synchronized from the REST API, as well.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
simplisafe:
  accounts:
    - username: !secret simplisafe_email
      password: !secret simplisafe_password

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@bachya bachya self-assigned this Apr 5, 2020
@probot-home-assistant probot-home-assistant bot added integration: simplisafe small-pr PRs with less than 30 lines. labels Apr 5, 2020
@project-bot project-bot bot added this to Needs review in Dev Apr 5, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 5, 2020
@bachya bachya merged commit c8df5fb into home-assistant:dev Apr 5, 2020
Dev automation moved this from By Code Owner to Done Apr 5, 2020
@bachya bachya deleted the simplisafe-state-sync branch April 5, 2020 16:47
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants