UniFi: Add UDM/P support

[Kane610]

Breaking change

Proposed change

Identify if controller runs on UniFi OS or not.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes Unifi Integration not working with Dream Machine Pro #31603
• This PR is related to issue: UDM Pro issue when using main function Kane610/aiounifi#13
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[monsieurlatte]

scrolling through looks like maybe this is now fixed? however I still get the error. I tried to change it to use port 80 because the controller doesnt run on 8443 anymore for UDM/P. Didnt work.

[Kane610]

Try 443

[monsieurlatte]

I did, I used my local ip 192.168.1.1 port 443 and then my unifi username and password, I also tried UBNT and my ssh password. I’m on 0.108.0 for HA.

…

On Apr 8, 2020, at 2:53 PM, Robert Svensson ***@***.***> wrote: Try 443 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#33766 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIV6MOPBC5A6NYUOAM5KUTRLTW7HANCNFSM4MCVNEFQ>.

[Kane610]

What does the debug logs say?

[monsieurlatte]

I get “bad credentials” Logger: homeassistant.components.unifi Source: components/unifi/controller.py:323 Integration: unifi (documentation <https://www.home-assistant.io/integrations/unifi>, issues <https://github.com/home-assistant/home-assistant/issues?q=is%3Aissue+is%3Aopen+label%3A%22integration%3A+unifi%22>) First occurred: 5:30:00 PM (1 occurrences) Last logged: 5:30:00 PM Unknown UniFi communication error occurred Traceback (most recent call last): File "/usr/src/homeassistant/homeassistant/components/unifi/controller.py", line 323, in get_controller await controller.login() File "/usr/local/lib/python3.7/site-packages/aiounifi/controller.py", line 68, in login await self.request("post", url, json=auth) File "/usr/local/lib/python3.7/site-packages/aiounifi/controller.py", line 151, in request raise ResponseError(f"Invalid content type: {res.content_type}") aiounifi.errors.ResponseError: Invalid content type: text/html

…

On Apr 8, 2020, at 3:19 PM, Robert Svensson ***@***.***> wrote: What does the debug logs say? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#33766 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABIV6MM2YYRPR4KCQ6KPVPLRLTZ5ZANCNFSM4MCVNEFQ>.

[Kane610]

I just realized you said you're trying it out on 0.108. The support is only on dev so far

[kiall]

Is this likely to land in 0.108.2, or 0.109.0? I'm not certain if this counts as a bugfix for a point release... Thanks for the fix :)

[Kane610]

This is not a bug fix. If you can please try it out on dev