Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nexia for thermostats without zoning #33770

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 7, 2020

Proposed change

  • Bump nexia to 0.8.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@project-bot project-bot bot added this to Needs review in Dev Apr 7, 2020
@bdraco bdraco added this to the 0.108.0 milestone Apr 7, 2020
@probot-home-assistant
Copy link

Hey there @ryannazaretian, mind taking a look at this pull request as its been labeled with a integration (nexia) you are listed as a codeowner for? Thanks!

@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Apr 7, 2020
@bdraco
Copy link
Member Author

bdraco commented Apr 7, 2020

test failure unrelated


/__w/_temp/b282b2ac-5f5b-4790-b296-af32ee67bd7b.sh: line 5: codecovToken: command not found
usage: codecov [-h] [--version] [--token TOKEN] [--file [FILE [FILE ...]]]
               [--flags [FLAGS [FLAGS ...]]] [--env [ENV [ENV ...]]]
               [--required] [--name NAME] [--gcov-root GCOV_ROOT]
               [--gcov-glob [GCOV_GLOB [GCOV_GLOB ...]]]
               [--gcov-exec GCOV_EXEC] [--gcov-args GCOV_ARGS]
               [-X [DISABLE [DISABLE ...]]] [--root ROOT] [--commit COMMIT]
               [--prefix PREFIX] [--branch BRANCH] [--build BUILD] [--pr PR]
               [--tag TAG] [--slug SLUG] [--url URL] [--cacert CACERT]
               [--dump] [-v] [--no-color]
codecov: error: argument --token/-t: expected one argument

@bdraco
Copy link
Member Author

bdraco commented Apr 7, 2020

root@ha-dev:~/home-assistant# pip3 install nexia
Requirement already satisfied: nexia in /usr/local/lib/python3.8/dist-packages (0.8.0)
proot@ha-dev:~/home-assistant# py.test tests/components/nexia/test_*.py
Test session starts (platform: linux, Python 3.8.1, pytest 5.3.5, pytest-sugar 0.9.2)
rootdir: /root/home-assistant, inifile: setup.cfg
plugins: requests-mock-1.7.0, aiohttp-0.3.0, cov-2.8.1, sugar-0.9.2, timeout-1.3.3, profiling-1.7.0
collecting ... 
 tests/components/nexia/test_binary_sensor.py ✓                                                                                           14% █▌        
 tests/components/nexia/test_climate.py ✓                                                                                                 29% ██▉       
 tests/components/nexia/test_config_flow.py ✓✓✓                                                                                           71% ███████▎  
 tests/components/nexia/test_scene.py ✓                                                                                                   86% ████████▋ 
 tests/components/nexia/test_sensor.py ✓                                                                                                 100% ██████████

Tested locally

@bdraco bdraco force-pushed the update_nexia_thermostats_without_zoning branch from 5f94ae5 to fa924b8 Compare April 7, 2020 15:05
@bdraco
Copy link
Member Author

bdraco commented Apr 7, 2020

More unreliable CI


ERROR: Could not find a version that satisfies the requirement pyW215==0.6.0 (from -r requirements_all.txt (line 1148)) (from versions: 0.5, 0.5.1, 0.5.2, 0.7.0)
ERROR: No matching distribution found for pyW215==0.6.0 (from -r requirements_all.txt (line 1148))

@bdraco
Copy link
Member Author

bdraco commented Apr 7, 2020

Since this is a dependency bump there isn't much point in trying to get the CI to behave

@bdraco bdraco merged commit 894aac1 into home-assistant:dev Apr 7, 2020
Dev automation moved this from By Code Owner to Done Apr 7, 2020
balloob pushed a commit that referenced this pull request Apr 7, 2020
@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Climate device missing with Nexia support
3 participants