-
-
Notifications
You must be signed in to change notification settings - Fork 29.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config flow for braviatv integration #33774
Add config flow for braviatv integration #33774
Conversation
Hey there @robbiet480, mind taking a look at this pull request as its been labeled with a integration ( |
@dcnielsen90 Could you take a look? |
My only comment was going to be the breaking change part -- but you beat me to it. The docs will need to be updated. Otherwise the config_flow and options work nicely. Nothing jumped out at me that might cause issues later. One thing that was kind of annoying was selecting all the sources I’d want to ignore – the list of sources I’d want to include is significantly shorter. It works either way (include vs exclude) and if it works nicely for the everyone else, I wouldn’t change it – I just probably would have done it the other way. |
@dcnielsen90 As for the source list. In my opinion, apps on the source list aren't a good solution because we aren't able to check which app is currently running. For example, we change the source to Netflix, Netflix starts, but in the integration the |
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
Co-Authored-By: Martin Hjelmare <marhje52@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Breaking change
Configuration of new instances will only be possible through Integration due to the lack of the
bravia.conf
file, which is necessary for YAML configuration. Existing instances will be imported intoconfig_entry
.Proposed change
This PR:
ignored sources
via options flowdevice_class
property to the entity classType of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: