Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docstring in test_util/aiohttp.py #34024

Merged
merged 1 commit into from Apr 11, 2020
Merged

Conversation

ziv1234
Copy link
Contributor

@ziv1234 ziv1234 commented Apr 11, 2020

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Apr 11, 2020
@project-bot project-bot bot added this to Needs review in Dev Apr 11, 2020
@springstan springstan changed the title fixed docstring in test_util/aiohttp.py Fix docstring in test_util/aiohttp.py Apr 11, 2020
Dev automation moved this from Needs review to Reviewer approved Apr 11, 2020
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃憤

@frenck frenck merged commit e88af54 into home-assistant:dev Apr 11, 2020
Dev automation moved this from Reviewer approved to Done Apr 11, 2020
@MartinHjelmare
Copy link
Member

MartinHjelmare commented Apr 11, 2020

There is one more here:

def stop(self):
"""Stop the current request and future ones. Avoids exception if there is someone waiting when exiting test."""

@ziv1234
Copy link
Contributor Author

ziv1234 commented Apr 11, 2020

There is one more here:

def stop(self):
"""Stop the current request and future ones. Avoids exception if there is someone waiting when exiting test."""

ok. fixed in PR #34040

@lock lock bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants